Bump version to 0.1.84

CHANGELOG.rst

@@ -1,6 +1,14 @@
 Change Log
 ===========
 
+0.1.84
+------
+- Make tz-cache thread-safe
+
+0.1.83
+------
+- Reduce spam-effect of tz-fetch
+
 0.1.81
 ------
 - Fix unhandled tz-cache exception #1107

test_yfinance.py

@@ -28,6 +28,9 @@ class TestTicker(unittest.TestCase):
             history = ticker.history(period="max")
             assert(history.empty is False and history is not None)
 
+        histories = yf.download(symbols, period="1yr")
+        assert(histories.empty is False and histories is not None)
+
     def test_attributes(self):
         for ticker in tickers:
             ticker.isin

yfinance/base.py

@@ -151,7 +151,7 @@ class TickerBase():
         if start or period is None or period.lower() == "max":
             # Check can get TZ. Fail => probably delisted
             try:
-                tz = self._get_ticker_tz()
+                tz = self._get_ticker_tz(debug_mode, proxy, timeout)
             except KeyError as e:
                 if "exchangeTimezoneName" in str(e):
                     shared._DFS[self.ticker] = utils.empty_df()
@@ -331,14 +331,14 @@ class TickerBase():
 
     # ------------------------
 
-    def _get_ticker_tz(self):
+    def _get_ticker_tz(self, debug_mode, proxy, timeout):
         if not self._tz is None:
             return self._tz
 
         tkr_tz = utils.cache_lookup_tkr_tz(self.ticker)
         if tkr_tz is None:
-            tkr_tz = self.info["exchangeTimezoneName"]
-            # info fetch is relatively slow so cache timezone
+            tkr_tz = self._fetch_ticker_tz(debug_mode, proxy, timeout)
+
             try:
                 utils.cache_store_tkr_tz(self.ticker, tkr_tz)
             except PermissionError:
@@ -348,6 +348,48 @@ class TickerBase():
         self._tz = tkr_tz
         return tkr_tz
 
+
+    def _fetch_ticker_tz(self, debug_mode, proxy, timeout):
+        # Query Yahoo for basic price data just to get returned timezone
+
+        params = {"range":"1d", "interval":"1d"}
+
+        # setup proxy in requests format
+        if proxy is not None:
+            if isinstance(proxy, dict) and "https" in proxy:
+                proxy = proxy["https"]
+            proxy = {"https": proxy}
+
+        # Getting data from json
+        url = "{}/v8/finance/chart/{}".format(self._base_url, self.ticker)
+
+        session = self.session or _requests
+        try:
+            data = session.get(url=url, params=params, proxies=proxy, headers=utils.user_agent_headers, timeout=timeout)
+            data = data.json()
+        except Exception as e:
+            if debug_mode:
+                print("Failed to get ticker '{}' reason: {}".format(self.ticker, e))
+            return None
+        else:
+            error = data.get('chart', {}).get('error', None)
+            if error:
+                # explicit error from yahoo API
+                if debug_mode:
+                    print("Got error from yahoo api for ticker {}, Error: {}".format(self.ticker, error))
+            else:
+                try:
+                    return data["chart"]["result"][0]["meta"]["exchangeTimezoneName"]
+                except Exception as err:
+                    if debug_mode:
+                        print("Could not get exchangeTimezoneName for ticker '{}' reason: {}".format(self.ticker, err))
+                        print("Got response: ")
+                        print("-------------")
+                        print(" {}".format(data))
+                        print("-------------")
+        return None
+
+
     def _get_info(self, proxy=None):
         # setup proxy in requests format
         if proxy is not None:

yfinance/utils.py

@@ -31,6 +31,9 @@ import sys as _sys
 import os as _os
 import appdirs as _ad
 
+from threading import Lock
+mutex = Lock()
+
 try:
     import ujson as _json
 except ImportError:
@@ -332,7 +335,9 @@ def cache_lookup_tkr_tz(tkr):
     if not _os.path.isfile(fp):
         return None
 
+    mutex.acquire()
     df = _pd.read_csv(fp)
+    mutex.release()
     f = df["Ticker"] == tkr
     if sum(f) == 0:
         return None
@@ -342,17 +347,21 @@ def cache_store_tkr_tz(tkr,tz):
     df = _pd.DataFrame({"Ticker":[tkr], "Tz":[tz]})
 
     dp = get_cache_dirpath()
+    mutex.acquire()
     if not _os.path.isdir(dp):
         _os.makedirs(dp)
     fp = _os.path.join(dp, "tkr-tz.csv")
     if not _os.path.isfile(fp):
         df.to_csv(fp, index=False)
+        mutex.release()
         return
 
     df_all = _pd.read_csv(fp)
     f = df_all["Ticker"]==tkr
     if sum(f) > 0:
+        mutex.release()
         raise Exception("Tkr {} tz already in cache".format(tkr))
 
     _pd.concat([df_all,df]).to_csv(fp, index=False)
+    mutex.release()
 

yfinance/version.py

@@ -1 +1 @@
-version = "0.1.81"
+version = "0.1.84"